Recipe Name:
Rewrite isBeforeNow to java.time equivalent
Description:
Rewrite isBeforeNow to java.time equivalent
Level:
warning
Language:
  • java
Tags:
  • framework specific
  • java.time
  • Joda-Time
  • quality
Documentation

Migrate from org.joda.time.DateTime to Java Time

Joda-Time DateTime migrates to java.time ZonedDateTime or OffsetDateTime.

ZonedDateTime is the same concept, date and time with time-zone.

OffsetDateTime is a new concept, date and time with offset from UTC.

Before 
    DateTime dateTime = new DateTime();
    int monthOfYear = dateTime.getMonthOfYear();
After 
    ZonedDateTime dateTime = ZonedDateTime.now();
    int monthOfYear = dateTime.getMonthValue();
References
Recipe 
id: scw:java.time:Joda-Time:DateTime-isBeforeNow
version: 10
metadata:
  name: Rewrite isBeforeNow to java.time equivalent
  shortDescription: Rewrite isBeforeNow to java.time equivalent
  level: warning
  language: java
  enabled: true
  comment: |
    Joda-Time's DateTime class provided an isBeforeNow method to conveniently check if the datetime is before the current Instant in time.
    This method is not available in java.time, but you can achieve the same result by using myZonedDateTime.isBefore(ZonedDateTime.now()) or myOffsetDateTime.isBefore(OffsetDateTime.now()).

    This recipe is designed to match on broken code as part of an overall Joda-Time to java.time migration. The method that is being searched for does not actually exist on ZoneDateTime/OffsetDateTime.
    After migrating a DateTime instance to a ZoneDateTime or OffsetDateTime, subsequent calls may be made to methods that existed for DateTime, but no longer exist for ZonedDateTime/OffsetDateTime.
    This recipe matches on the methodname that no longer exists, and suggests an equivalent rewrite that will work for java.time.
  descriptionFile: descriptions/datetime.html
  tags: framework specific;java.time;Joda-Time;quality
search:
  methodcall:
    name: isBeforeNow
    anyOf:
    - type: java.time.OffsetDateTime
    - type: java.time.ZonedDateTime
availableFixes:
- name: Rewrite to isBefore(<type>.now())
  actions:
  - rewrite:
      to: '{{{ qualifier }}}.isBefore({{{ qualifier.type }}}.now())'