Recipe Name:
Use AssertJ's isNotNull() instead of is(notNullValue())
Description:
Can be replaced with AssertJ style assertions
Level:
warning
Language:
  • java
Tags:
  • AssertJ
  • Hamcrest
Recipe
id: scw:assertj:hamcrest-is-not-null-value
version: 10
metadata:
  name: Use AssertJ's isNotNull() instead of is(notNullValue())
  shortDescription: Can be replaced with AssertJ style assertions
  level: warning
  language: java
  enabled: true
  tags: AssertJ; Hamcrest
search:
  methodcall:
    name: assertThat
    anyOf:
    - args:
        2:
          value:
            is:
              methodcall:
                args:
                  1:
                    value:
                      is:
                        methodcall:
                          name: notNullValue
                          type:
                            reference:
                              matches: org\.hamcrest\.(CoreMatchers|Matchers|core\.IsNull)
                            checkInheritance: true
                name: is
                type:
                  reference:
                    matches: org\.hamcrest\.(CoreMatchers|Matchers|core\.Is)
                  checkInheritance: true
      argCount: 2
    - args:
        1:
          type: String
        3:
          value:
            is:
              methodcall:
                args:
                  1:
                    value:
                      is:
                        methodcall:
                          name: notNullValue
                          type:
                            reference:
                              matches: org\.hamcrest\.(CoreMatchers|Matchers|core\.IsNull)
                            checkInheritance: true
                name: is
                type:
                  reference:
                    matches: org\.hamcrest\.(CoreMatchers|Matchers|core\.Is)
                  checkInheritance: true
      argCount: 3
    type: org.hamcrest.MatcherAssert
availableFixes:
- doStaticImports: true
  name: Change to assertThat(actual).isNotNull()
  availableIf:
    markedElement:
      is:
        methodcall:
          argCount: 2
  actions:
  - rewrite:
      to: org.assertj.core.api.Assertions.assertThat({{{ arguments.0 }}}).isNotNull()
- doStaticImports: true
  name: Change to assertThat(actual).as(reason).isNotNull()
  availableIf:
    markedElement:
      is:
        methodcall:
          argCount: 3
  actions:
  - rewrite:
      to: org.assertj.core.api.Assertions.assertThat({{{ arguments.1 }}}).as({{{ arguments.0 }}}).isNotNull()